Messages in this thread | | | Date | Mon, 12 Nov 2007 14:31:41 +0100 | From | Adrian Bunk <> | Subject | Re: [linux-usb-devel] [2.6 patch] usb/serial/oti6858.c: cleanups |
| |
On Mon, Nov 12, 2007 at 02:14:36PM +0100, Oliver Neukum wrote: > Am Montag 12 November 2007 schrieb Adrian Bunk: > > On Mon, Nov 05, 2007 at 09:40:43PM +0100, Oliver Neukum wrote: > > > Am Montag 05 November 2007 schrieb Adrian Bunk: > > > > This patch containsthe following cleanups: > > > > - make the needlessly global send_data() static > > > > - an author without anemail address is OK, not a FIXME > > > > > > That should be up to the author. If he thinks it should be there it might > > > be worth a FIXME > > > > I would be very surprised if the reason for these FIXMEs was different > > from the driver submitter not knowing a current address of the author... > > Is there any evidence the author didn't submit it?
Look at commit 49cdee0ed0fce9e1bda81f5dcad8d5cce6aec983.
> > > > - directly put the IDs into the id_table > > > > > > Why? > > > > I don't have a strong opinion on this one, but my impression was that > > there's generally a move away from using once-used #define's for such > > stuff. > > Well, vendor IDs should be centralised. >...
It was #define OTI6858_VENDOR_ID 0x0ea0
And the only other usages of this vendor ID are in drivers/usb/storage/unusual_devs.h where vendor ID defines do not seem to be used at all...
> Regards > Oliver
cu Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |