Messages in this thread | | | From | Oliver Neukum <> | Subject | Re: [linux-usb-devel] [2.6 patch] usb/serial/oti6858.c: cleanups | Date | Mon, 12 Nov 2007 14:14:36 +0100 |
| |
Am Montag 12 November 2007 schrieb Adrian Bunk: > On Mon, Nov 05, 2007 at 09:40:43PM +0100, Oliver Neukum wrote: > > Am Montag 05 November 2007 schrieb Adrian Bunk: > > > This patch containsthe following cleanups: > > > - make the needlessly global send_data() static > > > - an author without anemail address is OK, not a FIXME > > > > That should be up to the author. If he thinks it should be there it might > > be worth a FIXME > > I would be very surprised if the reason for these FIXMEs was different > from the driver submitter not knowing a current address of the author...
Is there any evidence the author didn't submit it?
> > > - directly put the IDs into the id_table > > > > Why? > > I don't have a strong opinion on this one, but my impression was that > there's generally a move away from using once-used #define's for such > stuff.
Well, vendor IDs should be centralised.
> > > - remove the now-empty oti6858.h > > > - kill the pointless driver version number > > > > Why? There might be a new version in the future. If the author put > > it there he might have had his reasons. > > A version number makes sense when there's a maintainer who is > maintaining and using it to identify different versions of a driver. > > But some ancient version number that contains less information than > "the version of this driver shipped with kernel 2.6.xy" doesn't have any > value.
Very well.
Regards Oliver - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |