lkml.org 
[lkml]   [2007]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] sysctl: Check length at deprecated_sysctl_warning.
    From
    Date
    Hello.

    Andrew Morton wrote:
    > I believe (args->nlen > CTL_MAXNAME) was correct.
    I'll leave it to you.
    But if you want to allow args->nlen == CTL_MAXNAME,
    you also need to update do_sysctl().

    int do_sysctl(int __user *name, int nlen, void __user *oldval, size_t __user *oldlenp,
    void __user *newval, size_t newlen)
    {
    ...
    if (nlen <= 0 || nlen >= CTL_MAXNAME)
    return -ENOTDIR;
    ...
    }

    Thanks.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-11-13 04:53    [W:0.021 / U:2.440 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site