Messages in this thread | | | Date | Sun, 11 Nov 2007 12:25:39 +0100 | From | Adrian Bunk <> | Subject | Re: [PATCH 1/6] Suppress A.OUT library support if !CONFIG_BINFMT_AOUT [try #5] |
| |
On Fri, Nov 09, 2007 at 03:34:37PM +0000, David Howells wrote: > Suppress A.OUT library support if CONFIG_BINFMT_AOUT is not set. > > Not all architectures support the A.OUT binfmt, so the ELF binfmt should not > be permitted to go looking for A.OUT libraries to load in such a case. Not > only that, but under such conditions A.OUT core dumps are not produced either. > > To make this work, this patch also does the following: > > (1) Makes the existence of the contents of linux/a.out.h more or less > contingent on one of: > > CONFIG_BINFMT_AOUT=[ym] > CONFIG_IA32_AOUT=[ym] > CONFIG_BINFMT_AOUT32=[ym] > > (2) Moves STACK_TOP[_MAX] out of asm/a.out.h and into asm/processor.h as > they're required whether or not A.OUT format is available. > > (3) Renames dump_thread() to aout_dump_thread() as it's only called by A.OUT > core dumping code. > > (4) Moves aout_dump_thread() into asm/a.out-core.h and makes it inline. This > is then included only where needed. This means that this bit of arch > code will be stored in the appropriate A.OUT binfmt module rather than > the core kernel. > > (5) Removes a lot of now obsolete {linux,asm}/a.out.h inclusions. > > (6) Drops A.OUT support for Blackfin (according to Mike Frysinger it's not > needed). >...
I do not like this patch for the following reasons: - too many cleanups lumped into one patch - it adds #ifdef's in fs/binfmt_elf.c for code that is anyway scheduled for removal in 2.6.25
cu Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |