[lkml]   [2007]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: Fw: Buffer overflow in CIFS VFS.
    Steve French wrote:
    > below. The obvious need is to create an SendReceive-NoResponse (or
    > equivalent) which
    > frees the SMB request buffer after send, and does not copy into an smb
    > response buffer. The following functions need to be changed to use
    How about modifying SendReceive to behave like that if NULL is passed as
    output buffer ?

    >> Obviously it is up to you, as a maintainer. I'd prefer adding a small
    >> header to each buffer with the buffer size and perhaps a type, or even a
    >> destructor function pointer. Simple macros could be used to obtain
    >> buffer size, given the buffer body pointer, or to dispose the buffer.
    >> That would save from checking the buffer type all over the code
    >> explicitly, or even worse, make strange assumptions about the type of
    >> buffer being passed - as we can see this is error-prone. That for a
    >> little cost of a few additional bytes per buffer.
    > That might be better, although without memory pools, this would perform
    > much worse
    Why ? I don't get your point here.


    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2007-11-10 14:05    [W:0.058 / U:15.472 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site