lkml.org 
[lkml]   [2007]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] Include header required for INT_MAX
    Date
    On Samstag, 10. November 2007, Christoph Hellwig wrote:
    > On Sat, Nov 10, 2007 at 03:55:15PM +0100, Thomas Koeller wrote:
    > > cdrom.h uses INT_MAX, so it must include kernel.h or
    > > limits.h (userspace) for a definition.
    >
    > Nack, we shoiuld never include userspace headers in kernel headers,
    > an even more never add !__KERNEL__ ifdefs. Just make sure your
    > programs include limit.h before including linux/cdrom.h.

    I think header files should be complete, and should not use undefined
    macros, picking up every random definition that may be in effect when
    the header is included, don't you agree? Why not use some other
    constant instead of INT_MAX? What improvement does commit
    132e4b0a049c39337c535501561b8301c7f2b202 provide? It certainly
    breaks existing userspace code.

    tk

    --
    Thomas Koeller
    thomas at koeller dot dyndns dot org
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-11-11 01:55    [W:0.020 / U:0.716 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site