lkml.org 
[lkml]   [2007]   [Oct]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 3/3] V4L: cinergyT2, remove bad usage of ERESTARTSYS
    From
    Date
    Hi Jiri,

    Em Seg, 2007-10-08 às 13:41 +0100, Jiri Slaby escreveu:
    > cinergyT2, remove bad usage of ERESTARTSYS
    >
    > test of cinergyt2->disconnect_pending doesn't ensure pending signal and so
    > ERESTARTSYS would reach userspace, which is not permitted. Change it to
    > EAGAIN
    >

    checkpatch.pl is complaining about your changeset:

    do not use assignment in if condition
    #82: FILE: drivers/media/dvb/cinergyT2/cinergyT2.c:492:
    + if ((err = mutex_lock_interruptible(&cinergyt2->wq_sem)))

    do not use assignment in if condition
    #86: FILE: drivers/media/dvb/cinergyT2/cinergyT2.c:495:
    + if ((err = mutex_lock_interruptible(&cinergyt2->sem)))

    do not use assignment in if condition
    #133: FILE: drivers/media/dvb/cinergyT2/cinergyT2.c:1036:
    + if ((err = mutex_lock_interruptible(&cinergyt2->wq_sem)))

    do not use assignment in if condition
    #137: FILE: drivers/media/dvb/cinergyT2/cinergyT2.c:1039:
    + if ((err = mutex_lock_interruptible(&cinergyt2->sem)))

    Please fix.

    Cheers,
    Mauro

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-10-10 09:55    [W:0.019 / U:31.472 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site