[lkml]   [2007]   [Oct]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: coding for optimizations (Re: [PATCH 1/2] i386: mce cleanup part1: functional change)
    On Tue, Oct 09, 2007 at 07:33:17PM +0200, wrote:
    > if (!mce_disabled) {
    > if (!(c->x86_capability & (X86_FEATURE_MCA | X86_FEATURE_MCE)) {
    > printk(KERN_INFO "CPU%i: No machine check support available\n",
    > smp_processor_id());
    > return;
    > }
    > /* function code */
    > }

    I have 2 problems with this way:

    1) It is totally broken because c->x86_capability is not an integer but
    an *array* of integers. This is also the reason why test_bit() is used
    in cpu_has() and not plain logical operators.

    2) It is still hard to read and breaks the kernel coding style.

    But you are right with the redundant mca and mce variables. They are not
    needed and I will inline the cpu_has() checks into the condition check.
    I'll resubmit tomorrow.

    | AMD Saxony Limited Liability Company & Co. KG
    Operating | Wilschdorfer Landstr. 101, 01109 Dresden, Germany
    System | Register Court Dresden: HRA 4896
    Research | General Partner authorized to represent:
    Center | AMD Saxony LLC (Wilmington, Delaware, US)
    | General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2007-10-09 20:33    [W:0.024 / U:31.176 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site