Messages in this thread Patch in this message | | | Date | Wed, 10 Oct 2007 01:13:28 +0900 | From | Akinobu Mita <> | Subject | [PATCH -mm] slub: fix cpu hotplug offline/online path |
| |
This patch fixes the problem introduced by: http://kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc8/2.6.23-rc8-mm2/broken-out/slub-place-kmem_cache_cpu-structures-in-a-numa-aware-way.patch
I got slub BUG report when I tried to do cpu hotplug/unplug $ while true; do echo 0 > /sys/devices/system/cpu/cpu1/online echo 1 > /sys/devices/system/cpu/cpu1/online done
This is because init_alloc_cpu_cpu() is called every time when the CPU is going to be onlined but init_alloc_cpu_cpu() is not intented to be called twice or more for same CPU. Then it breaks kmem_cache_cpu_free list for the CPU.
This patch removes init_alloc_cpu_cpu() from cpu hotplug notifier. But call it for each possible CPUs not only online CPUs at initialization time.
Cc: Christoph Lameter <clameter@sgi.com> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
--- mm/slub.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
Index: 2.6-mm/mm/slub.c =================================================================== --- 2.6-mm.orig/mm/slub.c +++ 2.6-mm/mm/slub.c @@ -2029,7 +2029,7 @@ static int alloc_kmem_cache_cpus(struct /* * Initialize the per cpu array. */ -static void init_alloc_cpu_cpu(int cpu) +static void __init init_alloc_cpu_cpu(int cpu) { int i; @@ -2041,7 +2041,7 @@ static void __init init_alloc_cpu(void) { int cpu; - for_each_online_cpu(cpu) + for_each_possible_cpu(cpu) init_alloc_cpu_cpu(cpu); } @@ -2973,7 +2973,6 @@ static int __cpuinit slab_cpuup_callback switch (action) { case CPU_UP_PREPARE: case CPU_UP_PREPARE_FROZEN: - init_alloc_cpu_cpu(cpu); down_read(&slub_lock); list_for_each_entry(s, &slab_caches, list) s->cpu_slab[cpu] = alloc_kmem_cache_cpu(s, cpu, - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |