lkml.org 
[lkml]   [2007]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: RFC: reviewer's statement of oversight
    On 10/8/07, Jan Engelhardt <jengelh@computergmbh.de> wrote:
    >
    > On Oct 8 2007 19:37, Sam Ravnborg wrote:
    > >snip...
    > >Acked-by:
    > >Tested-by:
    >
    > * Used by random people to express their (dis)like/experience with the
    > patch.
    >
    > >Reviewed-by:
    >
    > * I am maintaner or an 'important' person and have had a
    > look at it in depth
    ---

    A couple of months ago there was a thread about Acked-by. At that time
    the consensus seemed to be that it was inappropriate for random people
    to add Acked-by - that it should only be added by people whose opinion
    was expected to a gate for merging. Did the Summit reach a decision
    that Acked-by was for anybody and Reviewed-by was for authorities?

    I like Randy's point - the assigning of weight to the Reviewer's
    opinion is necessarily in the hands of those at the top of the merge
    process and there's no need to ask reviewers to decide whether their
    opinion matters. In that view, "Acked-by" means "I have no objection
    to this patch, but don't claim deep review" and "Reviewed-by" means "I
    have no objection to this patch after a thorough review", and either
    can be attached by anybody who wants to express an opinion.

    scott
    --
    scott preece
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-10-08 21:37    [W:0.022 / U:33.116 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site