lkml.org 
[lkml]   [2007]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: RFC: reviewer's statement of oversight
    Mark Gross wrote:
    > On Mon, Oct 08, 2007 at 11:24:45AM -0600, Jonathan Corbet wrote:
    >> (a) I have carried out a technical review of this patch to evaluate its
    >> appropriateness and readiness for inclusion into the mainline kernel.
    [...]
    >> (c) While there may (or may not) be things which could be improved with
    >> this submission, I believe that it is, at this time, (1) a
    >> worthwhile addition to the kernel, and (2) free of serious known
    >> issues which would argue against its inclusion.
    >
    > C-1 "worthwhile addition..." Probably shouldn't be part of this. That's
    > what additional Signed off by ACK's provide. I think reviewed by should
    > limit its scope to code correctness leaving the subjective "worthwhile"
    > statements are better expressed with other tags.

    A patch which is not "worthwhile" is also not "appropriate". Mere
    correctness in a mathematical sense is not enough as technical review
    criterion.
    --
    Stefan Richter
    -=====-=-=== =-=- -=---
    http://arcgraph.de/sr/
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-10-08 20:57    [W:0.041 / U:148.648 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site