Messages in this thread Patch in this message | | | Date | Thu, 04 Oct 2007 13:27:40 +0200 | From | Martin Schwidefsky <> | Subject | [patch 34/34] vmwatchdog: fix broken inline assembly. |
| |
From: Heiko Carstens <heiko.carstens@de.ibm.com>
Constraint for err is wrong since it is preinitialized and the code relies on it in case of an exception.
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com> Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com> ---
drivers/s390/char/vmwatchdog.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Index: quilt-2.6/drivers/s390/char/vmwatchdog.c =================================================================== --- quilt-2.6.orig/drivers/s390/char/vmwatchdog.c +++ quilt-2.6/drivers/s390/char/vmwatchdog.c @@ -66,8 +66,8 @@ static int __diag288(enum vmwdt_func fun "0: la %0,0\n" "1:\n" EX_TABLE(0b,1b) - : "=d" (err) : "d"(__func), "d"(__timeout), - "d"(__cmdp), "d"(__cmdl), "0" (-EINVAL) : "1", "cc"); + : "+d" (err) : "d"(__func), "d"(__timeout), + "d"(__cmdp), "d"(__cmdl) : "1", "cc"); return err; } -- blue skies, Martin.
"Reality continues to ruin my life." - Calvin.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |