lkml.org 
[lkml]   [2007]   [Oct]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 43/51] [DLM] Make dlm_sendd cond_resched more
    Date
    From: Patrick Caulfield <pcaulfie@redhat.com>

    Under high recovery loads dlm_sendd can monopolise the CPU and cause soft lockups.

    This one extra and one moved cond_resched() make it yield a little more during
    such times keeping work moving.

    Signed-Off-By: Patrick Caulfield <pcaulfie@redhat.com>
    Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>

    diff --git a/fs/dlm/lowcomms.c b/fs/dlm/lowcomms.c
    index 62a8a6c..58bf3f5 100644
    --- a/fs/dlm/lowcomms.c
    +++ b/fs/dlm/lowcomms.c
    @@ -1264,14 +1264,15 @@ static void send_to_sock(struct connection *con)
    if (len) {
    ret = sendpage(con->sock, e->page, offset, len,
    msg_flags);
    - if (ret == -EAGAIN || ret == 0)
    + if (ret == -EAGAIN || ret == 0) {
    + cond_resched();
    goto out;
    + }
    if (ret <= 0)
    goto send_error;
    - } else {
    + }
    /* Don't starve people filling buffers */
    cond_resched();
    - }

    spin_lock(&con->writequeue_lock);
    e->offset += ret;
    --
    1.5.1.2
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-10-04 11:37    [W:0.020 / U:29.636 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site