Messages in this thread | | | Date | Tue, 30 Oct 2007 21:14:04 -0700 (PDT) | Subject | Re: tipc_config.h requires linux/string.h, which does not exist in exported headers | From | David Miller <> |
| |
From: David Miller <davem@davemloft.net> Date: Tue, 30 Oct 2007 15:31:54 -0700 (PDT)
> From: Sam Ravnborg <sam@ravnborg.org> > Date: Tue, 30 Oct 2007 23:20:25 +0100 > > > Something like this.. > > I like it - much better than adding string.h to unidef-y. > > PS - had not pulled latest -linus - so you must update Kbuild. > > PPS - tipc.h should be exported too as I understood Stephen. > > tipc.h is already listed in header-y. > > I'll merge your patch, thanks Sam.
Unfortunately I have to back it out, it breaks the build.
In file included from net/tipc/core.h:41, from net/tipc/addr.c:37: include/linux/tipc_config.h: In function 'TLV_SET': include/linux/tipc_config.h:306: error: implicit declaration of function 'memcpy' include/linux/tipc_config.h:306: warning: incompatible implicit declaration of built-in function 'memcpy'
I truly think adding linux/string.h to unifdef-y along with:
#ifndef __KERNEL__ #include <string.h> #else ... #endif
in linux/string.h is a much cleaner and less error prone solution :-) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |