lkml.org 
[lkml]   [2007]   [Oct]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 2/6] kobject: check for duplicate names in kobject_rename
    Date
    This should catch any duplicate names before we try to tell sysfs to
    rename the object. This happens a lot with older versions of udev and
    the network rename scripts.

    Cc: David Miller <davem@davemloft.net>
    Cc: Kay Sievers <kay.sievers@vrfy.org>
    Cc: Rafael J. Wysocki <rjw@sisk.pl>
    Cc: Tejun Heo <htejun@gmail.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    ---
    lib/kobject.c | 13 +++++++++++++
    1 files changed, 13 insertions(+), 0 deletions(-)

    diff --git a/lib/kobject.c b/lib/kobject.c
    index 03d4036..a7e3bf4 100644
    --- a/lib/kobject.c
    +++ b/lib/kobject.c
    @@ -308,6 +308,19 @@ int kobject_rename(struct kobject * kobj, const char *new_name)
    if (!kobj->parent)
    return -EINVAL;

    + /* see if this name is already in use */
    + if (kobj->kset) {
    + struct kobject *temp_kobj;
    + temp_kobj = kset_find_obj(kobj->kset, new_name);
    + if (temp_kobj) {
    + printk(KERN_WARNING "kobject '%s' can not be renamed "
    + "to '%s' as '%s' is already in existance.\n",
    + kobject_name(kobj), new_name, new_name);
    + kobject_put(temp_kobj);
    + return -EINVAL;
    + }
    + }
    +
    devpath = kobject_get_path(kobj, GFP_KERNEL);
    if (!devpath) {
    error = -ENOMEM;
    --
    1.5.3.4
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-10-31 06:17    [W:0.020 / U:29.748 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site