Messages in this thread | | | Date | Tue, 30 Oct 2007 17:38:58 +0000 | From | Christoph Hellwig <> | Subject | Re: [PATCH 3/8] scsi: megaraid_sas - add module param max_sectors, cmd_per_lun |
| |
On Mon, Oct 01, 2007 at 11:51:48AM -0400, bo yang wrote: > +/* > + * Number of sectors per IO command will be set in megasas_init_mfi > + * if user does not provide > + */ > +static unsigned int max_sectors; > +module_param_named(max_sectors, max_sectors, int, 0); > +MODULE_PARM_DESC(max_sectors, > + "Maximum number of sectors per IO command"); > + > +/* > + * Number of cmds per logical unit > + */ > +static unsigned int cmd_per_lun = MEGASAS_DEFAULT_CMD_PER_LUN; > +module_param_named(cmd_per_lun, cmd_per_lun, int, 0); > +MODULE_PARM_DESC(cmd_per_lun, > + "Maximum number of commands per logical unit (default=128)");
I don't think this should be in drivers. cmd_per_lun is a scsi_host attribute already and you should change the mid-layer to add an optional host template method that allows the sysfs file to be writeable. max_sectors should be handled similar although we don't seem to have an attribute for it yet (maybe the block layer does?)
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |