lkml.org 
[lkml]   [2007]   [Oct]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/2] [CRYPTO] tcrypt: Move sg_init_table out of timing loops
    On Tue, Oct 30 2007, Herbert Xu wrote:
    > On Tue, Oct 30, 2007 at 06:50:58AM +0100, Jens Axboe wrote:
    > >
    > > How so? The reason you changed it to sg_init_table() + sg_set_buf() is
    > > exactly because sg_init_one() didn't properly init the entry (as they
    > > name promised).
    >
    > For one of the cases yes but the other one repeatedly calls
    > sg_init_one on the same sg entry while we really only need
    > to initialise it once and call sg_set_buf afterwards.
    >
    > Normally this is irrelevant but the loops in question are
    > trying to estimate the speed of the algorithms so it's good
    > to exclude as much noise from them as possible.

    Ah OK, I was referring to the replacement mentioned above.

    --
    Jens Axboe

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-10-30 15:23    [W:3.857 / U:0.956 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site