Messages in this thread | | | Date | Tue, 30 Oct 2007 15:06:20 +0100 | From | Patrick McHardy <> | Subject | Re: [PATCH] nf_nat_h323.c unneeded rcu_dereference() calls |
| |
Paul E. McKenney wrote: > Hello! > > While reviewing rcu_dereference() uses, I came across a number of cases > where I couldn't see how the rcu_dereference() helped. One class of > cases is where the variable is never subsequently dereferenced, so that > patches like the following one would be appropriate. > > So, what am I missing here?
Nothing, it was mainly intended as documentation that the hooks are protected by RCU. I agree that its probably more confusing this way since we're not even in a rcu_read_lock protected section.
I've queued a patch to remove them all. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |