Messages in this thread | | | Subject | RE: [PATCH resend] Make the dev_*() family of macros in device.hcomplete | Date | Tue, 30 Oct 2007 05:11:24 -0700 | From | "Medve Emilian-EMMEDVE1" <> |
| |
Hi Greg K-H,
> > +#define dev_info(dev, format, arg...) \ > > + dev_printk(KERN_INFO, dev, format, ## arg) > > + > > #ifdef DEBUG > > #define dev_dbg(dev, format, arg...) \ > > - dev_printk(KERN_DEBUG , dev , format , ## arg) > > + dev_printk(KERN_DEBUG, dev, format, ## arg) > > Those extra spaces are there for a good reason, older versions of gcc > are broken without it. So please, put them all back...
You mean I should add spaces before commas only where they were initially or to all new code and/or macros? I've observed other kernel code and more often there are no spaces before commas. I'm asking because the CodingStyle document is not very explicit about this rule.
Thank you, Emil. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |