Messages in this thread | | | Date | Wed, 03 Oct 2007 17:26:57 -0700 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH 5/5] lguest: loading bzImage directly |
| |
Rusty Russell wrote: > On Wed, 2007-10-03 at 10:37 +0100, Chris Malley wrote: >> Hi guys >> >> Would it not be clearer to #include <asm/bootparam.h> and use >> the relevant named members of struct setup_header / struct boot_params >> rather than the hard-coded values 0x202, 0x1F1, 0x214 ? > > Yes, but unfortunately bootparam.h wasn't designed to be included from > userspace. > > The patch would look like this, but it makes me wonder if it'd be better > to put all these user-exposed types in bootparam.h and have the other > headers include them. hpa? >
I don't have a strong preference either way, but I think what you have here is fine.
-hpa
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |