Messages in this thread | | | Date | Mon, 29 Oct 2007 19:08:35 -0400 | From | Jeff Garzik <> | Subject | Re: [RFC] Create instrumentation directory (git repository) |
| |
Mathieu Desnoyers wrote: > * Jeff Garzik (jeff@garzik.org) wrote: >> Randy Dunlap wrote: >>> On Mon, 29 Oct 2007 17:51:38 -0400 Mathieu Desnoyers wrote: >>> >>>> Hi, >>>> >>>> Since we already have the Instrumentation menu in >>>> kernel/Kconfig.instrumentation and instrumentation code all over the >>>> kernel tree: >>>> >>>> arch/*/oprofile/*.c >>>> kernel/kprobes.c >>>> arch/*/kernel/kprobes.c >>>> kernel/marker.c >>>> kernel/profile.c >>>> kernel/lockdep.c >>>> vm/vmstat.c >>>> block/blktrace.c >>>> drivers/base/power/trace.c >>>> >>>> We could move them to >>>> >>>> instrumentation/ >>>> arch/*/instrumentation/ >>>> >>>> Therefore, we could also move the kprobes and marker samples under >>>> >>>> instrumentation/samples/ >>>> >>>> Here is a link to a git repository containing the changes, based on >>>> 2.6.24-rc1: >>>> >>>> git://ltt.polymtl.ca/linux-2.6-instrumentation.git >>>> instrumentation-for-linus >>>> (the interesting range is : v2.6.24-rc1..instrumentation-for-linus) >>>> >>>> Through the gitweb interface: >>>> http://ltt.polymtl.ca/cgi-bin/gitweb.cgi?p=linux-2.6-instrumentation.git >>>> >>>> Feedback is appreciated. Sorry for the huge CC list, but the change >>>> involves many maintainers. >>> Two more added. Jeff Garzik and Christoph H. sometimes have some comments >>> about this. >>> >>> It would be helpful if we could get comments on this in the next day >>> or two [instead of in 1-2 weeks]. >> "instrumentation" is long, and painful to the fingers :) >> > > Quoting my post from last week: > >> My main concern is that 15 characters long directory name might be >> inelegant (however, it only beats Documentation by 2). > > And quoting the answer from Valdis.Kletnieks@vt.edu : > How so? i n s esc. 4 keystrokes (and still 2 more than D<ESC> ;) > > > > Better suggestions are wery welcome. However, in modern shells, > auto-completion is cheap nowadays.
That is no excuse for extreme verbosity. It makes ls(1) displays ugly, it makes diffstat ugly, it causes long pathnames to be truncated in various display-oriented programs.
Pick a shorter word like probes or profile or what... or better yet... just leave most things in their current directories.
Shuffling files around just to put them into directories with extra-long names is highly undesirable.
Jeff
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |