Messages in this thread | | | Date | Mon, 29 Oct 2007 19:58:04 +0100 | From | Jens Axboe <> | Subject | Re: [PATCH] Clean up scatterlist.h and introduce macros for readability. |
| |
On Mon, Oct 29 2007, Robert P. J. Day wrote: > > Add some macros to <linux/scatterlist.h> to make the bit manipulation > more readable, and expand on some of the documentation. > > This patch incorporates content from Cyrill Gorcunov > <gorcunov@gmail.com> as well.
I don't like it, I already explained why I don't consider the 'magic' values a problem. The use of the bits is supposed to be scatterlist.h private and the values are documented at the top of that include file.
-- Jens Axboe
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |