lkml.org 
[lkml]   [2007]   [Oct]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] sysfs: add filter function to groups
    From
    Date
    On Mon, 2007-10-29 at 11:57 -0500, James Bottomley wrote:
    > On Mon, 2007-10-29 at 17:54 +0100, Kay Sievers wrote:
    > > On Mon, 2007-10-29 at 10:16 -0500, James Bottomley wrote:

    > > > struct attribute_group {
    > > > const char *name;
    > > > + int (*filter_show)(struct kobject *, int);
    > >
    > > Are you sure that you want to return an array index here, instead of the
    > > actual attribute? Like:
    >
    > Actually, it returns a true/false value indicating whether the given
    > attribute should be displayed.

    It isn't about the return value of the function, that's fine. You call
    back with the index number (int) of the array of attributes, instead of
    passing the attribute pointer (struct attribute *attr) back to ask the
    device for the attribute to create.

    Kay

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-10-29 18:27    [W:0.041 / U:31.192 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site