lkml.org 
[lkml]   [2007]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[2.6 patch] video/sis/: fix negative array index
    This patch fixes the possible usage of a negative value as an array 
    index spotted by the Coverity checker.

    Signed-off-by: Adrian Bunk <bunk@kernel.org>

    ---

    drivers/video/sis/sis_main.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    9f63bf8c543710521e885b09d88271d1a308b158
    diff --git a/drivers/video/sis/sis_main.c b/drivers/video/sis/sis_main.c
    index bc7d236..37bd24b 100644
    --- a/drivers/video/sis/sis_main.c
    +++ b/drivers/video/sis/sis_main.c
    @@ -1245,24 +1245,25 @@ sisfb_do_set_var(struct fb_var_screeninfo *var, int isactive, struct fb_info *in
    ivideo->sisfb_mode_idx++;
    }

    if(found_mode) {
    ivideo->sisfb_mode_idx = sisfb_validate_mode(ivideo,
    ivideo->sisfb_mode_idx, ivideo->currentvbflags);
    - ivideo->mode_no = sisbios_mode[ivideo->sisfb_mode_idx].mode_no[ivideo->mni];
    } else {
    ivideo->sisfb_mode_idx = -1;
    }

    if(ivideo->sisfb_mode_idx < 0) {
    printk(KERN_ERR "sisfb: Mode %dx%dx%d not supported\n", var->xres,
    var->yres, var->bits_per_pixel);
    ivideo->sisfb_mode_idx = old_mode;
    return -EINVAL;
    }

    + ivideo->mode_no = sisbios_mode[ivideo->sisfb_mode_idx].mode_no[ivideo->mni];
    +
    if(sisfb_search_refresh_rate(ivideo, ivideo->refresh_rate, ivideo->sisfb_mode_idx) == 0) {
    ivideo->rate_idx = sisbios_mode[ivideo->sisfb_mode_idx].rate_idx;
    ivideo->refresh_rate = 60;
    }

    if(isactive) {
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-10-27 16:23    [W:0.021 / U:210.012 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site