Messages in this thread | | | Subject | Re: [PATCH] proc_fs.h redux | From | Joe Perches <> | Date | Sat, 27 Oct 2007 15:40:04 -0700 |
| |
On Sat, 2007-10-27 at 23:47 +0400, Alexey Dobriyan wrote: > Remove proc_fs.h from headers that doesn't really need it.
> --- a/arch/powerpc/kernel/process.c > +++ b/arch/powerpc/kernel/process.c > @@ -17,6 +17,7 @@ > #include <linux/errno.h> > #include <linux/sched.h> > #include <linux/kernel.h> > +#include <linux/fs.h>
Your code doesn't match your patch description.
You've got new includes of:
<linux/fs.h> <linux/proc_fs.h> <linux/err.h> <linux/kref.h>
and forward declarations of
struct proc_dir_entry; struct file_operations;
As a general rule, I think it better to use includes than use naked forward declarations.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |