lkml.org 
[lkml]   [2007]   [Oct]   [26]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateFri, 26 Oct 2007 15:54:13 -0700
FromZach Brown <>
SubjectRe: [PATCH] Fix bad data from non-direct-io read after direct-io write
Linus Torvalds wrote:
> 
> On Fri, 26 Oct 2007, Zach Brown wrote:
>> I think that test should be changed to
> 
> How about not testing at all? Which was what the old code did.
> 
> Just do the invalidate unconditionally for any writes, and screw the end 
> result of the invalidate, since we cannot afford to overwrite the previous 
> return value anyway in any realistic scenario?

I'm reasonably comfortable with that, sure.  This second invalidation
only catches reads which userspace raced with the write, and that's
already racy by definition.

I can throw together a patch if you haven't already committed one by the
time you read this ;).

- z
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-10-27 00:57    [from the cache]
©2003-2008