Messages in this thread | | | Date | Thu, 25 Oct 2007 01:46:15 -0700 | From | Stephane Eranian <> | Subject | Re: [PATCH] IA64/perfmon: kill dead code, clean irq handling |
| |
Jeff,
On Tue, Oct 23, 2007 at 07:09:08PM -0400, Jeff Garzik wrote: > > By deleting unused code, this makes perfmon irq handling more efficient, > as well as reducing code size. > > * remove unused pfm_install_alt_pmu_interrupt() > * remove unused pfm_remove_alt_pmu_interrupt() > I have not problem with the patch except maybe for those two functions. How do you know they are not used? Have you checked the VTUNE open-source driver? I thought at some point they were using this hook.
> * remove now-unused pfm_alt_intr_handler pointer, and associated > function call in perfmon interrupt handler. > > * remove unused 'irq' argument from pfm_do_interrupt_handler() > > * un-indent code in pfm_interrupt_handler() now that > pfm_alt_intr_handler is no longer used. > -- -Stephane - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |