lkml.org 
[lkml]   [2007]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] ISDN/capidrv: fix casting warning
    Date
    drivers/isdn/capi/capidrv.c: In function 'if_sendbuf':
    drivers/isdn/capi/capidrv.c:1865: warning: cast from pointer to integer
    of different size

    We are passing a kernel pointer, skb->data, but the interface itself is
    limited to 32 bits. A future changeset may want to mark this code
    32-bit only, if it turns out cmsg->Data value truncation on 64-bit
    platforms is problematic in practice.

    Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
    ---
    drivers/isdn/capi/capidrv.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/drivers/isdn/capi/capidrv.c b/drivers/isdn/capi/capidrv.c
    index 44f954d..a4814e1 100644
    --- a/drivers/isdn/capi/capidrv.c
    +++ b/drivers/isdn/capi/capidrv.c
    @@ -1862,7 +1862,7 @@ static int if_sendbuf(int id, int channel, int doack, struct sk_buff *skb)
    datahandle = nccip->datahandle;
    capi_fill_DATA_B3_REQ(&sendcmsg, global.ap.applid, card->msgid++,
    nccip->ncci, /* adr */
    - (u32) skb->data, /* Data */
    + (unsigned long) skb->data, /* Data */
    skb->len, /* DataLength */
    datahandle, /* DataHandle */
    0 /* Flags */
    --
    1.5.2.4
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-10-25 10:11    [W:0.021 / U:118.304 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site