lkml.org 
[lkml]   [2007]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/4] [x86] : Add support for the RDC R-321x SoC
    On Tue, 16 Oct 2007 13:41:31 +0200
    Florian Fainelli <florian.fainelli@telecomint.eu> wrote:

    > +static struct {
    > + struct completion stop;
    > + volatile int running;
    > + struct timer_list timer;
    > + volatile int queue;
    > + int default_ticks;
    > + unsigned long inuse;
    > +} rdc321x_wdt_device;

    Why the volatiles? If these actually help then it's probably an indication
    that something is wrong in the implementation.

    Documentation/volatile-considered-harmful.txt has some details.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-10-25 23:29    [W:0.021 / U:29.732 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site