Messages in this thread | | | Subject | RE: [2.6 patch] unexport tick_nohz_get_sleep_length | Date | Thu, 25 Oct 2007 09:51:03 -0700 | From | "Pallipadi, Venkatesh" <> |
| |
>-----Original Message----- >From: Thomas Gleixner [mailto:tglx@linutronix.de] >Sent: Thursday, October 25, 2007 2:28 AM >To: Adrian Bunk >Cc: Brown, Len; LKML; Pallipadi, Venkatesh >Subject: Re: [2.6 patch] unexport tick_nohz_get_sleep_length > >On Wed, 24 Oct 2007, Adrian Bunk wrote: > >> This patch removes the unused >> EXPORT_SYMBOL_GPL(tick_nohz_get_sleep_length). >> >> Signed-off-by: Adrian Bunk <bunk@kernel.org> >> >> --- >> f7c83dfe117f4fd072b2506ae090e4145abda362 >> diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c >> index 10a1347..5997456 100644 >> --- a/kernel/time/tick-sched.c >> +++ b/kernel/time/tick-sched.c >> @@ -320,8 +320,6 @@ ktime_t tick_nohz_get_sleep_length(void) >> return ts->sleep_length; >> } >> >> -EXPORT_SYMBOL_GPL(tick_nohz_get_sleep_length); >> - > >Hmm, this was added to allow the cpuidle governers modular >build. Seems this was changed to compiled in only. > >Len, Venki, is this the final decision ? >
Yes. This was done recently for proper fallback to old ACPI policy in case CPUIDLE is not selected. With that being module, falling back to ACPI policy at run time makes things ugly.
Thanks, Venki - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |