Messages in this thread | | | Date | Thu, 25 Oct 2007 01:10:32 -0400 | From | Jeff Garzik <> | Subject | Re: [PATCH] napi: use non-interruptible sleep in napi_disable |
| |
Benjamin Herrenschmidt wrote: > The current napi_disable() uses msleep_interruptible() but doesn't > (and can't) exit in case there's a signal, thus ending up doing a > hot spin without a cpu_relax. Use uninterruptible sleep instead. > > Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> > --- > > include/linux/netdevice.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: linux-work/include/linux/netdevice.h > =================================================================== > --- linux-work.orig/include/linux/netdevice.h 2007-10-17 12:39:16.000000000 +1000 > +++ linux-work/include/linux/netdevice.h 2007-10-17 12:45:00.000000000 +1000 > @@ -390,7 +390,7 @@ static inline void napi_complete(struct > static inline void napi_disable(struct napi_struct *n) > { > while (test_and_set_bit(NAPI_STATE_SCHED, &n->state)) > - msleep_interruptible(1); > + msleep(1); > }
ACK
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |