lkml.org 
[lkml]   [2007]   [Oct]   [25]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    DateThu, 25 Oct 2007 10:16:44 +0200
    FromTakashi Iwai <>
    SubjectRe: [patch] portman2x4.c: fix boot hang
    At Wed, 24 Oct 2007 21:44:17 +0200,
    Ingo Molnar wrote:
    > 
    > Subject: portman2x4.c: fix boot hang
    > From: Ingo Molnar <mingo@elte.hu>
    > 
    > when booting an allyesconfig bzImage kernel the bootup hangs in the 
    > portman2x4 driver (on a box that does not have this hardware), at:
    > 
    >  Pid: 1, comm:              swapper
    >  EIP: 0060:[<c02f763c>] CPU: 0
    >  EIP is at parport_pc_read_status+0x4/0x8
    >   EFLAGS: 00000202    Not tainted  (2.6.23-rc9 #904)
    >  EAX: f7e57a7f EBX: 00000010 ECX: c2b808c0 EDX: 00000379
    >  ESI: f7cb8230 EDI: 00000010 EBP: f7cb8230 DS: 007b ES: 007b FS: 0000
    >  CR0: 8005003b CR2: fff9c000 CR3: 007ec000 CR4: 00000690
    >  DR0: 00000000 DR1: 00000000 DR2: 00000000 DR3: 00000000
    >  DR6: ffff0ff0 DR7: 00000400
    >   [<c04613de>] portman_flush_input+0xde/0x12c
    >   [<c0461a24>] snd_portman_probe+0x368/0x484
    >   [<c02fbb8c>] __device_attach+0x0/0x8
    >   [<c02fce68>] platform_drv_probe+0xc/0x10
    >   [<c02fba6c>] driver_probe_device+0x74/0x194
    >   [<c0587174>] klist_next+0x38/0x70
    >   [<c02fbb8c>] __device_attach+0x0/0x8
    >   [<c02faea1>] bus_for_each_drv+0x35/0x68
    >   [<c02fbc22>] device_attach+0x72/0x78
    > 
    > the reason is due to an inconsistent error return code of 1 or 2, while 
    > snd_portman_probe only realizes negative error codes.
    > 
    > with this fixed the probe fails as it should and the bootup continues.
    > 
    > Signed-off-by: Ingo Molnar <mingo@elte.hu>
    
    Thanks.  But isn't the patch below easier?
    
    
    Takashi
    
    diff -r 09088524dd7f drivers/portman2x4.c
    --- a/drivers/portman2x4.c	Thu Oct 25 11:46:24 2007 +0200
    +++ b/drivers/portman2x4.c	Thu Oct 25 11:49:17 2007 +0200
    @@ -668,7 +668,7 @@ static int __devinit snd_portman_probe_p
     	parport_release(pardev);
     	parport_unregister_device(pardev);
     
    -	return res;
    +	return res ? -EIO : 0;
     }
     
     static void __devinit snd_portman_attach(struct parport *p)
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at  http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at  http://www.tux.org/lkml/
    
    \
     
     \ /
      Last update: 2007-10-25 11:55    [from the cache]
    ©2003-2008