lkml.org 
[lkml]   [2007]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [2.6 patch] blackfin: "extern inline" -> "static inline"
Mike Frysinger wrote:
> On 10/24/07, Jie Zhang <jzhang.linux@gmail.com> wrote:
>> On 10/25/07, Adrian Bunk <bunk@kernel.org> wrote:
>>> "extern inline" will have different semantics with gcc 4.3.
>>>
>>> Signed-off-by: Adrian Bunk <bunk@kernel.org>
>>>
>>> --- a/include/asm-blackfin/string.h
>>> +++ b/include/asm-blackfin/string.h
>>> @@ -4,7 +4,7 @@
>>> #ifdef __KERNEL__ /* only set these up for kernel code */
>>>
>>> #define __HAVE_ARCH_STRCPY
>>> -extern inline char *strcpy(char *dest, const char *src)
>>> +static inline char *strcpy(char *dest, const char *src)
>>> {
>>> char *xdest = dest;
>>> char temp = 0;
>> What if we compile it with gcc 4.1?
>
> we'll have to either use the gcc attributes to force old inline
> behavior or use the gcc flag to force it

We should probably have an extern_inline define then, assuming this is a
function that does exist in a linkable version already -- otherwise
"static inline" is correct.

-hpa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-10-25 05:09    [from the cache]
©2003-2011 Jasper Spaans