Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [RFC PATCH 4/5] Remove CPU_DEAD/CPU_UP_CANCELLED handling from workqueue.c | Date | Wed, 24 Oct 2007 17:21:04 +1000 |
| |
On Wednesday 24 October 2007 15:37:16 Gautham R Shenoy wrote: > @@ -712,7 +712,7 @@ static void start_workqueue_thread(struc > > if (p != NULL) { > if (cpu >= 0) > - kthread_bind(p, cpu); > + set_cpus_allowed(p, cpumask_of_cpu(cpu)); > wake_up_process(p); > }
Hi Gautham!
This works, although the change is unnecessary. If you're going to do this I'd prefer "if (set_cpus_allowed(p, cpumask_of_cpu(cpu)) != 0) BUG();".
Cheers, Rusty. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |