lkml.org 
[lkml]   [2007]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC PATCH 4/5] Remove CPU_DEAD/CPU_UP_CANCELLED handling from workqueue.c
    On 10/24, Rusty Russell wrote:
    >
    > On Wednesday 24 October 2007 15:37:16 Gautham R Shenoy wrote:
    > > @@ -712,7 +712,7 @@ static void start_workqueue_thread(struc
    > >
    > > if (p != NULL) {
    > > if (cpu >= 0)
    > > - kthread_bind(p, cpu);
    > > + set_cpus_allowed(p, cpumask_of_cpu(cpu));
    > > wake_up_process(p);
    > > }
    >
    > Hi Gautham!
    >
    > This works, although the change is unnecessary.

    kthread_bind() changes ->cpu/->cpus_allowed without any locks.

    Currently this is possible because nobody can wakeup the new thread
    after wait_task_inactive() succeeds. With this patch this is not true
    any longer, cwq->thread can sleep, for example, on cwq->more_work.

    Oleg.

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-10-24 15:41    [W:2.279 / U:0.636 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site