lkml.org 
[lkml]   [2007]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH -mm 11/11] aacraid: use pci_set_dma_max_seg_size
    FUJITA Tomonori wrote:
    > This sets the segment size limit properly via pci_set_dma_max_seg_size
    > and remove blk_queue_max_segment_size because scsi-ml calls it.
    >
    > Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
    > ---
    > drivers/scsi/aacraid/linit.c | 9 ++++++---
    > 1 files changed, 6 insertions(+), 3 deletions(-)
    >
    > diff --git a/drivers/scsi/aacraid/linit.c b/drivers/scsi/aacraid/linit.c
    > index 038980b..04d6a65 100644
    > --- a/drivers/scsi/aacraid/linit.c
    > +++ b/drivers/scsi/aacraid/linit.c
    > @@ -435,9 +435,6 @@ static int aac_slave_configure(struct scsi_device *sdev)
    > else if (depth < 2)
    > depth = 2;
    > scsi_adjust_queue_depth(sdev, MSG_ORDERED_TAG, depth);
    > - if (!(((struct aac_dev *)host->hostdata)->adapter_info.options &
    > - AAC_OPT_NEW_COMM))
    > - blk_queue_max_segment_size(sdev->request_queue, 65536);
    > } else
    > scsi_adjust_queue_depth(sdev, 0, 1);
    >
    > @@ -1045,6 +1042,12 @@ static int __devinit aac_probe_one(struct pci_dev *pdev,
    > if (error < 0)
    > goto out_deinit;
    >
    > + if (!(aac->adapter_info.options & AAC_OPT_NEW_COMM)) {
    > + error = pci_set_dma_max_seg_size(pdev, 65536);
    > + if (error)
    > + goto out_deinit;
    > + }


    is this needed, given that the default is already 65536?

    Jeff



    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-10-24 13:35    [W:0.044 / U:149.500 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site