lkml.org 
[lkml]   [2007]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 4/5] NET: Make ts_recent_stamp unsigned
    From
    From: Chuck Lever <chuck.lever@oracle.com>
    Date: Tue, 23 Oct 2007 11:44:28 -0400

    > The get_seconds() function returns an unsigned long. To prevent incorrect
    > comparison results between values saved in ts_recent_stamp and later
    > invocations of get_seconds(), change the type of ts_recent_stamp to match
    > the return type of get_seconds().
    >
    > Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
    > Cc: <netdev@vger.kernel.org>

    I see two potential problems with this patch:

    1) If you update struct tcp_options_received you should also
    update struct tcp_timewait_sock similarly.

    The fact that you missed this suggests that you didn't
    grep the tree to see how else this variable is used and
    this makes me extra concerned about this patch's correctness.

    2) There are computations in the TCP stack using this member that
    probably care about the signedness, such as:

    net/ipv4/tcp_ipv4.c: get_seconds() - tcptw->tw_ts_recent_stamp > 1))) {
    include/net/tcp.h: if (get_seconds() >= rx_opt->ts_recent_stamp + TCP_PAWS_24DAYS)
    include/net/tcp.h: if (get_seconds() >= rx_opt->ts_recent_stamp + TCP_PAWS_24DAYS)

    We should make sure we understand what is expected here, and
    why it would still be correct after making both ts_recent_stamp
    members unsigned.

    Thanks.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-10-24 06:03    [W:6.564 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site