[lkml]   [2007]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectIDE crash...

    I'm debugging a blk_rq_map_sg() crash that i'm getting on sparc64 as
    root is mounted over IDE. I think I know what is happening now.

    The IDE sg table is allocated and initialized like this in

    x = kmalloc(sizeof(struct scatterlist) * nents, GFP_XXX);
    sg_init_table(x, nents);

    So far, so good.

    Now, ide_map_sg() passes requests down to blk_rq_map_sg() like this in

    hwif->sg_nents = blk_rq_map_sg(drive->queue, rq, sg);

    Ok, so what does blk_rq_map_sg() do?

    sg = NULL;
    rq_for_each_segment(bvec, rq, iter) {
    if (bvprv && cluster) {
    } else {
    if (!sg)
    sg = sglist;
    sg = sg_next(sg);
    bvprv = bvec;
    } /* segments in rq */

    if (sg)

    So let's say the first request comes in and needs 2 segs.
    This will mark sg[1].page_link with 0x2

    If the next request from IDE needs 4 segs, we'll OOPS because
    sg_next() on &sg[1] will see page_link bit 0x2 is set and
    therefore return NULL.

    A quick look shows that if you're testing on SCSI (or something
    layered on top of it like SATA or PATA) you won't see this seemingly
    guarenteed crash because the SCSI mid-layer allocates a fresh sglist
    via mempool_alloc() and runs sg_init_table() on it for every I/O
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2007-10-23 08:53    [W:0.019 / U:57.664 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site