lkml.org 
[lkml]   [2007]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/2] irq_flags_t: intro and core annotations
    On Mon, 22 Oct 2007 16:29:12 +0100 Ralf Baechle <ralf@linux-mips.org> wrote:

    > On Sun, Oct 21, 2007 at 01:30:42PM +0400, Alexey Dobriyan wrote:
    >
    > > irq_flags_t
    > >
    > > New type for use with spin_lock_irqsave() and friends.
    >
    > Talking about it, why did we ever require this to be a long anyway? I could
    > get away with a single bit for MIPS; the rest of this variable is pure
    > bloat. An abstract datatype could help finally fix this.
    >

    Yes, it's always been ugly that we use unsigned long for this rather than
    abstracting it properly.

    However I'd prefer that we have some really good reason for introducing
    irq_flags_t now. Simply so that I don't needlessly spend the next two
    years wrestling with literally thousands of convert-to-irq_flags_t patches
    and having to type "please use irq_flags_t here" in hundreds of patch
    reviews. (snivel, wimper)
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-10-22 20:31    [W:0.022 / U:29.456 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site