lkml.org 
[lkml]   [2007]   [Oct]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: BUG at mm/filemap.c:1749 (2.6.24, jffs2, unionfs)
From
Date
On Fri, 2007-10-19 at 17:16 +1000, Nick Piggin wrote:
>
> if (writtenlen) {
> - if (inode->i_size < (pg->index << PAGE_CACHE_SHIFT) + start + writtenlen) {
> - inode->i_size = (pg->index << PAGE_CACHE_SHIFT) + start + writtenlen;
> + if (inode->i_size < pos + start + writtenlen) {
> + inode->i_size = pos + start + writtenlen;

This part seems wrong. Shouldn't it just be pos + writtenlen -- which is
basically what it was already: pos==(pg->index<<PAGE_CACHE_SHIFT)+start

--
dwmw2

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-10-21 10:59    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site