lkml.org 
[lkml]   [2007]   [Oct]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: nfsv2 ref leak in 2.6.24?
In message <1192985892.7505.32.camel@heimdal.trondhjem.org>, Trond Myklebust writes:
>
> On Sat, 2007-10-20 at 17:35 -0400, Erez Zadok wrote:
>
> > Trond, I verified that w/ the above patch the problem is w/ nfs: the client
> > leaves .nfsXXX files behind for every file unlinked while open. Let me know
> > when you get a fix and I'll test it.
>
> Doh... Another typo.
>
> Trond
> -------------------------- CUT HERE --------------------
> From: Trond Myklebust <Trond.Myklebust@netapp.com>
> Date: Sun, 21 Oct 2007 12:02:22 -0400
> NFS: Fix a typo in nfs_call_unlink()
>
> Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
> ---
>
> fs/nfs/unlink.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/nfs/unlink.c b/fs/nfs/unlink.c
> index ce558c2..233ad38 100644
> --- a/fs/nfs/unlink.c
> +++ b/fs/nfs/unlink.c
> @@ -171,7 +171,7 @@ static int nfs_call_unlink(struct dentry *dentry, struct nfs_unlinkdata *data)
> if (parent == NULL)
> goto out_free;
> dir = parent->d_inode;
> - if (nfs_copy_dname(dentry, data) == 0)
> + if (nfs_copy_dname(dentry, data) != 0)
> goto out_dput;
> /* Non-exclusive lock protects against concurrent lookup() calls */
> spin_lock(&dir->i_lock);

With this patch, all my nfs2/3/4 tests passed just fine.

Thanks,
Erez.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-10-22 00:21    [W:1.037 / U:0.124 seconds]
©2003-2014 Jasper Spaans. Advertise on this site