Messages in this thread | | | Date | Sat, 20 Oct 2007 17:11:19 +0100 | From | Christoph Hellwig <> | Subject | Re: [PATCH] compat_ioctl: introduce generic_compat_ioctl helper |
| |
On Sat, Oct 20, 2007 at 05:50:57PM +0200, Arnd Bergmann wrote: > Many drivers use only compatible ioctl numbers. In order to > avoid having to write a special compat_ioctl handler for each > of them or listing every ioctl number in fs/compat_ioctl.c, > let's introduce a generic handler that simply calls the > driver specific f_op->unlocked_ioctl() or f_op->ioctl() handler.
At least for the unlocked_ioctl case this is not nessecary because the driver an simply set both the unlocked_ioctl and compat_ioctl handlers to the same function. For the drivers not using unlocked_ioctl yet a function like this makes sense in theory, but I'd prefer to just switch them to ->unlocked_ioctl.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |