lkml.org 
[lkml]   [2007]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    SubjectRe: 2.6.23-rc7-mm1 -- powerpc rtas panic
    From
    On Tue, Oct 02, 2007 at 06:28:19PM -0500, Linas Vepstas wrote:
    > On Mon, Sep 24, 2007 at 01:35:31PM +0100, Andy Whitcroft wrote:
    > > Seeing the following from an older power LPAR, pretty sure we had
    > > this in the previous -mm also:
    >
    > I haven't forgetten about this ... and am looking at it now.
    > Seems that whenever I go to reserve the machine pSeries-102,
    > someone else is using it :-)

    This panic is caused by "[POWERPC] pseries: Fix jumbled no_logging flag."
    (79c0108d1b9db4864ab77b2a95dfa04f2dcf264c), in the powerpc/for-2.6.24
    branch. It looks to me that we have logging enabled too early now.

    I think the following is a reasonable fix?

    ---
    Explicitly enable RTAS error logging, when it should be ready.


    Signed-off-by: Tony Breeds <tony@bakeyournoodle.com>

    ---

    arch/powerpc/platforms/pseries/rtasd.c | 7 ++++++-
    1 files changed, 6 insertions(+), 1 deletions(-)

    diff --git a/arch/powerpc/platforms/pseries/rtasd.c b/arch/powerpc/platforms/pseries/rtasd.c
    index 30925d2..0df5d0d 100644
    --- a/arch/powerpc/platforms/pseries/rtasd.c
    +++ b/arch/powerpc/platforms/pseries/rtasd.c
    @@ -54,7 +54,10 @@ static unsigned int rtas_event_scan_rate;
    static int full_rtas_msgs = 0;

    /* Stop logging to nvram after first fatal error */
    -static int no_more_logging;
    +static int no_more_logging = 1; /* Until we initialize everything,
    + * make sure we don't try logging
    + * anything */
    +

    static int error_log_cnt;

    @@ -414,6 +417,8 @@ static int rtasd(void *unused)
    memset(logdata, 0, rtas_error_log_max);
    rc = nvram_read_error_log(logdata, rtas_error_log_max,
    &err_type, &error_log_cnt);
    + /* We can use rtas_log_buf now */
    + no_more_logging = 0;

    if (!rc) {
    if (err_type != ERR_FLAG_ALREADY_LOGGED) {
    Yours Tony

    linux.conf.au http://linux.conf.au/ || http://lca2008.linux.org.au/
    Jan 28 - Feb 02 2008 The Australian Linux Technical Conference!
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-10-03 02:29    [W:2.363 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site