lkml.org 
[lkml]   [2007]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v2 5/6] Sysace: Move IRQ handler registration to occur after FSM is initialized
    From
    Date

    On Sun, 2007-09-30 at 16:57 -0600, Grant Likely wrote:
    > val |= ACE_CTRL_DATABUFRDYIRQ | ACE_CTRL_ERRORIRQ;
    > ace_out(ace, ACE_CTRL, val);
    >
    > + /* Now we can hook up the irq handler */
    > + if (ace->irq != NO_IRQ) {
    > + rc = request_irq(ace->irq, ace_interrupt, 0,
    > "systemace", ace);
    > + if (rc) {
    > + /* Failure - fall back to polled mode */
    > + dev_err(ace->dev, "request_irq failed\n");
    > + ace->irq = NO_IRQ;
    > + }
    > + }
    > +

    I don't know the HW but from the above, it looks like you enable
    interrupt emission on the HW before you register the handler, which is
    wrong. You should make sure on the contrary that IRQs on the HW are
    disabled until after you have registered a handler.

    Only really a problem if you have shared interrupts but still...

    Ben.

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-10-02 07:59    [W:0.043 / U:0.044 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site