lkml.org 
[lkml]   [2007]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 07/30] IGET: Stop BEFS from using iget() and read_inode()
    From
    Date
    On Tue, 2007-10-02 at 13:32 +0100, David Howells wrote:
    > Zach Brown <zab@zabbo.net> wrote:
    >
    > > /* haha, continuing the fine tradition of terrible names in this api.. */
    > > static inline void *PTR_PTR(void *err_ptr) {
    > > BUG_ON(!IS_ERR(err_ptr) || !err_ptr);
    > > return err_ptr;
    > > }
    >
    > How about ERR_CAST() instead? Or maybe CAST_ERR()?

    It's a better name than PTR_PTR(). :-)
    >
    > struct dentry *blah(...)
    > {
    > struct inode *inode;
    >
    > inode = thing(...);
    > if (IS_ERR(inode))
    > return ERR_CAST(inode);
    > }
    >
    > Where ERR_CAST is defined as:
    >
    > static inline void *ERR_CAST(const void *error)
    > {
    > return (void *) x;
    > }

    Of course, the cast is unnecessary, and I'm sure you meant to return
    error:

    static inline void *ERR_CAST(const void *error)
    {
    return error;
    }

    Shaggy
    --
    David Kleikamp
    IBM Linux Technology Center

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-10-02 15:09    [W:0.039 / U:0.108 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site