lkml.org 
[lkml]   [2007]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: BUG at mm/filemap.c:1749 (2.6.24, jffs2, unionfs)
    In message <200710191716.53470.nickpiggin@yahoo.com.au>, Nick Piggin writes:
    [...]
    > Hmm, looks like jffs2_write_end is writing more than we actually ask it
    > to, and returns that back.
    >
    > unsigned aligned_start = start & ~3;
    >
    > and
    >
    > if (end == PAGE_CACHE_SIZE) {
    > /* When writing out the end of a page, write out the
    > _whole_ page. This helps to reduce the number of
    > nodes in files which have many short writes, like
    > syslog files. */
    > start = aligned_start = 0;
    > }
    >
    > These "longer" writes are fine, but they shouldn't get propagated back
    > to the vm/vfs. Something like the following patch might fix it.
    >
    >
    > --Boundary-00=_lnFGHwOggSRGKPd
    > Content-Type: text/x-diff;
    > charset="utf-8";
    > name="jffs2-writtenlen-fix.patch"
    > Content-Transfer-Encoding: 7bit
    > Content-Disposition: attachment;
    > filename="jffs2-writtenlen-fix.patch"

    Nick, the patch worked. All of my unionfs-over-jffs2 tests passed.

    Thanks,
    Erez.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-10-19 19:45    [W:0.046 / U:29.840 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site