Messages in this thread | | | From | Nick Piggin <> | Subject | Re: [RFC][PATCH] block: Isolate the buffer cache in it's own mappings. | Date | Thu, 18 Oct 2007 15:10:48 +1000 |
| |
On Thursday 18 October 2007 13:59, Eric W. Biederman wrote: > If filesystems care at all they want absolute control over the buffer > cache. Controlling which buffers are dirty and when. Because we > keep the buffer cache in the page cache for the block device we have > not quite been giving filesystems that control leading to really weird > bugs.
Mmm. Like I said, when a live filesystem is mounted on a bdev, it isn't like you want userspace to go dancing around on it without knowing exactly what it is doing.
The kernel more or less does the right thing here with respect to the *state* of the data[*] (that is, buffer heads and pagecache). It's when you actually start changing the data itself around is when you'll blow up the filesystem.
[*] The ramdisk code is simply buggy, right? (and not the buffer cache)
The idea of your patch in theory is OK, but Andrew raises valid points about potential coherency problems, I think.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |