lkml.org 
[lkml]   [2007]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRE: [PATCH 5/5] I/OAT: Add completion callback for async_tx interface use
Date
From
>From: David Miller [mailto:davem@davemloft.net] 
>
>From: Andrew Morton <akpm@linux-foundation.org>
>Date: Wed, 17 Oct 2007 17:44:38 -0700
>
>> On Wed, 17 Oct 2007 17:14:39 -0700
>> Shannon Nelson <shannon.nelson@intel.com> wrote:
>>
>> > + tx->callback = (void *)ioat_dma_test_callback;
>>
>> and when I remove this cast I get
>>
>> drivers/dma/ioat_dma.c: In function 'ioat_dma_self_test':
>> drivers/dma/ioat_dma.c:718: warning: assignment from
>incompatible pointer type
>>
>> because ioat_dma_test_callback isn't void-returning.
>Something is wrong
>> here. I assume that ioat_dma_test_callback() should just be
>> void-returning?
>
>In fact this might crash on systems that conditionally pop
>return values based upon whether the function is void or not.
>

Yep - thanks. That's my misuse of Dan's dma_async_tx_callback typedef.

sln
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-10-18 02:55    [W:0.327 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site