![]() | |||||||||||||
Messages in this thread |
On Wed, Oct 17 2007, Linus Torvalds wrote: > > > On Wed, 17 Oct 2007, Linus Torvalds wrote: > > > > So I think your change to use "sg_next()" only when you actually need a > > next pointer is the correct one after all. > > That still leaves the initialization issue. The link pointers need to all > be initialized at SG allocation time (and not just the last one for the > case where it's a linked entry). > > And if you initialize them at allocation time, does an allocation ever get > re-used without being free'd in between (if it does, you do indeed need to > initialize the non-link pointers each time - but I don't see it being the > case, so ..) The links will not change, so reuse should actually be OK. The reuse cannot be larger than the original would hold, but that would be a bug without chaining as well of course. WRT reuse, if we end up requeuing a request, than we will go through the whole thing again. I don't think Ingo is hitting that either, though. -- Jens Axboe - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | ||||||||||||
| Last update: 2007-10-17 20:43 [from the cache] ©2003-2008 | |||||||||||||