lkml.org 
[lkml]   [2007]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [bug] block subsystem related crash with latest -git


On Wed, 17 Oct 2007, Linus Torvalds wrote:
>
> So I think your change to use "sg_next()" only when you actually need a
> next pointer is the correct one after all.

That still leaves the initialization issue. The link pointers need to all
be initialized at SG allocation time (and not just the last one for the
case where it's a linked entry).

And if you initialize them at allocation time, does an allocation ever get
re-used without being free'd in between (if it does, you do indeed need to
initialize the non-link pointers each time - but I don't see it being the
case, so ..)

Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-10-17 20:25    [W:0.426 / U:0.160 seconds]
©2003-2011 Jasper Spaans. Advertise on this site